perf(MMU): discard CallStackReader #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francois Bojarski <[email protected]>
This was
linked to
issues
Aug 27, 2024
Signed-off-by: Francois Bojarski <[email protected]>
Signed-off-by: Francois Bojarski <[email protected]>
Signed-off-by: Francois Bojarski <[email protected]>
letypequividelespoubelles
changed the title
Signed-off-by: Francois Bojarski <[email protected]>
letypequividelespoubelles
requested review from
OlivierBBB and
lorenzogentile404
OlivierBBB
approved these changes
Aug 28, 2024
.../src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/opcode/CodeCopy.java
Show resolved
Hide resolved
...on/src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/opcode/Create.java
Show resolved
Hide resolved
...n/src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/opcode/Create2.java
Outdated
Show resolved
Hide resolved
.../src/main/java/net/consensys/linea/zktracer/module/mmio/instructions/LimbToRamOneTarget.java
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/mmu/MmuOperation.java
Show resolved
Hide resolved
|
@letypequividelespoubelles This column is not in the trace, but is defined in the constraints. |
Signed-off-by: Francois Bojarski <[email protected]>
letypequividelespoubelles
deleted the
feat/issue-917/re-connect-ram-mmummio
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a clean-up of the MMU. As MMU is not triggered during execution anymore, but is given by the HUB the relevant memory infos in MmuCall, we can discard the callStackReader.
I introduce a better structure for MMIO's instructions to delete code duplicate too.